From 40ad773ca7946f0b6deb043facb36ecb12481aaf Mon Sep 17 00:00:00 2001 From: Fredrik Wahlberg Date: Thu, 22 Jan 2004 20:23:46 +0000 Subject: [PATCH] Fixed bug with update errors not being reported. --- dnsupdate.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/dnsupdate.py b/dnsupdate.py index 09a39ff..fe7fe68 100644 --- a/dnsupdate.py +++ b/dnsupdate.py @@ -155,7 +155,6 @@ def update(msg): import dns.query import dns.tsigkeyring import dns.update - # The name of the key and the secret keyring = dns.tsigkeyring.from_text({ msg['keyname']: msg['keysecret'] @@ -174,9 +173,9 @@ def update(msg): try: response = dns.query.tcp(update, '217.78.32.198') except: - msg['error'].append("An error has occurred, check your keyname and keysecret.") + msg['error'].append("An error occurred in the server communication.") return - + # Verify response if not msg.has_key('quiet'): if response.rcode() == 0: @@ -247,7 +246,7 @@ if __name__=="__main__": err = checkerror(msg) if err == 0: update(msg) - checkerror(msg) + err = checkerror(msg) if err == 0: sys.exit(0)